Skip to content

Add regression test for too-big by-value ABI args#158978

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ap4sh:ap4sh/issue-148853-abi-layout-test
Jul 9, 2026
Merged

Add regression test for too-big by-value ABI args#158978
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ap4sh:ap4sh/issue-148853-abi-layout-test

Conversation

@Ap4sh

@Ap4sh Ap4sh commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Fixes #148853

Adds a regression test for a huge extern "C" by-value argument that used to ICE while computing the exported symbol ABI. Current rustc reports the expected too big for the target architecture layout error instead

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 8, 2026
@rustbot

rustbot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@workingjubilee

Copy link
Copy Markdown
Member

Thanks.

@workingjubilee

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 40251d7 has been approved by workingjubilee

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Jul 9, 2026
…t-test, r=workingjubilee

Add regression test for too-big by-value ABI args

Fixes rust-lang#148853

Adds a regression test for a huge `extern "C"` by-value argument that used to ICE while computing the exported symbol ABI. Current rustc reports the expected `too big for the target architecture` layout error instead
rust-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
Rollup of 23 pull requests

Successful merges:

 - #158968 (stdarch subtree update)
 - #154445 (rustdoc: Represent `--output-format=json` coverage and ir differently)
 - #158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS)
 - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`)
 - #158870 (std: merge the unix-like io::error modules into one file)
 - #158920 (Update wasm-component-ld to 0.5.26)
 - #158926 (wrapping_sh* methods: clarify underspecified reference)
 - #158927 (add core test run with `-Zforce-intrinsic-fallback`)
 - #158932 (Do not build the compiler when invoking `x perf compare`)
 - #158937 (Emit the emscripten entry point as `__main_argc_argv`)
 - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`)
 - #156144 (Better docs for PartialEq (includes macro rename))
 - #156548 ( Library support for aarch64-unknown-linux-pauthtest target)
 - #157995 (`Vec::dedup_by` docs explicit function argument order)
 - #158307 (CI job for parallel frontend ui tests)
 - #158741 (Simplify `Option::into_flat_iter` signature)
 - #158807 (Add regression test for CString::clone_into unwind safety)
 - #158862 (Fix the span for parameter suggestion )
 - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic)
 - #158902 (add codegen test for range length bound propagation)
 - #158913 (Update `browser-ui-test` version to `0.24.1`)
 - #158935 (std: support real fd methods on Emscripten)
 - #158978 (Add regression test for too-big by-value ABI args)
@rust-bors rust-bors Bot merged commit 6152879 into rust-lang:main Jul 9, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 9, 2026
rust-timer added a commit that referenced this pull request Jul 9, 2026
Rollup merge of #158978 - Ap4sh:ap4sh/issue-148853-abi-layout-test, r=workingjubilee

Add regression test for too-big by-value ABI args

Fixes #148853

Adds a regression test for a huge `extern "C"` by-value argument that used to ICE while computing the exported symbol ABI. Current rustc reports the expected `too big for the target architecture` layout error instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: fn_abi_of_instance(Instance { def: Item(DefId(0:195 ~ bigty[1d5a]::foo)), args: [] }) failed

4 participants