add core test run with -Zforce-intrinsic-fallback#158927
Open
folkertdev wants to merge 1 commit into
Open
Conversation
Collaborator
|
|
Member
It is a concern, I agree, but bootstrap does actually print the cmdline that it was executing if it fails, and the flag should be visible in the cmdline. We could make that output be more.. screaming :) if need be. The change is fine by me, you can r=me. |
Contributor
Author
|
Well apparently it's not caused issues before (neither optimize for size nor the miri version of the fallback flag) so it's probably fine for now. @bors r+ |
Contributor
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jul 8, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
…uwer Rollup of 18 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - #158902 (add codegen test for range length bound propagation) - #158913 (Update `browser-ui-test` version to `0.24.1`) - #158935 (std: support real fd methods on Emscripten) - #158951 (Merge three `MaxUniverse`s into one)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
…uwer Rollup of 18 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - #158902 (add codegen test for range length bound propagation) - #158913 (Update `browser-ui-test` version to `0.24.1`) - #158935 (std: support real fd methods on Emscripten) - #158951 (Merge three `MaxUniverse`s into one)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
…uwer Rollup of 18 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #150946 (intrinsics: Add a fallback for non-const libm float functions) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23) - #158894 (Make the ordering of non-terminal binds in ambiguity error messages deterministic) - #158902 (add codegen test for range length bound propagation) - #158913 (Update `browser-ui-test` version to `0.24.1`) - #158935 (std: support real fd methods on Emscripten) - #158951 (Merge three `MaxUniverse`s into one)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 8, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
…uwer Rollup of 25 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #158968 (stdarch subtree update) - #154445 (rustdoc: Represent `--output-format=json` coverage and ir differently) - #156370 (Reject linked dylib EII default overrides) - #157153 (allow `Allocator`s to be used as `#[global_allocator]`s) - #158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158912 (Introduce new bootstrap config section for PGO configuration) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #158932 (Do not build the compiler when invoking `x perf compare`) - #158937 (Emit the emscripten entry point as `__main_argc_argv`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #156548 ( Library support for aarch64-unknown-linux-pauthtest target) - #158307 (CI job for parallel frontend ui tests) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158741 (Simplify `Option::into_flat_iter` signature) - #158807 (Add regression test for CString::clone_into unwind safety) - #158862 (Fix the span for parameter suggestion ) - #158883 (tests: fix enum-match.rs to handle LLVM 23)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 8, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 8, 2026
Rollup of 25 pull requests Successful merges: - #158871 (add relnotes for 1.97.0) - #158968 (stdarch subtree update) - #157690 (codegen_ssa: pack small const aggregates into immediate stores) - #158541 (Move `std::io::Write` to `core::io`) - #154445 (rustdoc: Represent `--output-format=json` coverage and ir differently) - #156370 (Reject linked dylib EII default overrides) - #157153 (allow `Allocator`s to be used as `#[global_allocator]`s) - #158495 (Rename HAS_CT_PROJECTION to HAS_CONST_ALIAS) - #158617 (allow mGCA const arguments to fall back to anon consts) - #158645 (Fix splat ICEs and ban it in closures) - #158655 (Fix coroutine MIR saved local remapping) - #158666 (Carry the `b_offset` inside `BackendRepr::ScalarPair`) - #158870 (std: merge the unix-like io::error modules into one file) - #158920 (Update wasm-component-ld to 0.5.26) - #158926 (wrapping_sh* methods: clarify underspecified reference) - #158927 (add core test run with `-Zforce-intrinsic-fallback`) - #158932 (Do not build the compiler when invoking `x perf compare`) - #158937 (Emit the emscripten entry point as `__main_argc_argv`) - #151379 (Stabilize `VecDeque::retain_back` from `truncate_front`) - #156144 (Better docs for PartialEq (includes macro rename)) - #156548 ( Library support for aarch64-unknown-linux-pauthtest target) - #158307 (CI job for parallel frontend ui tests) - #158347 (Improve generic parameters handling for #[diagnostic::on_const]) - #158722 (delegation: do not always inherit `ConstArgHasType` predicates) - #158741 (Simplify `Option::into_flat_iter` signature)
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 9, 2026
…=folkertdev add core test run with `-Zforce-intrinsic-fallback` Some discussion at [#t-infra > CI for -Zforce-intrinsic-fallback](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20for.20-Zforce-intrinsic-fallback/with/608129693). In rust-lang#158377 we added `-Zforce-intrinsic-fallback` which will use an intrinsic's fallback body if there is one. I'm basing this on rust-lang#125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them. One concern I have is how clearly it is reported that the `optimize_for_size` or `-Zforce-intrinsic-fallback` runs fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time. r? Kobzol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some discussion at #t-infra > CI for -Zforce-intrinsic-fallback.
In #158377 we added
-Zforce-intrinsic-fallbackwhich will use an intrinsic's fallback body if there is one.I'm basing this on #125011, but for now only run the core tests which I think should be sufficient? But maybe I'm missing something, or maybe the alloc/std tests are fast enough that we might as well run them.
One concern I have is how clearly it is reported that the
optimize_for_sizeor-Zforce-intrinsic-fallbackruns fail. Because in those cases the standard run succeeded, and so if you miss that an extra flag was passed that can waste a lot of debugging time.r? Kobzol