ci: fix LinuxTools PR builder missing environment variables#62757
Merged
Conversation
This allows the use of sccache to compile LLVM, and should fix toolstate not working.
Contributor
|
This comment has been minimized.
This comment has been minimized.
Member
|
r=me on the strategy here |
e6fd95f to
9926868
Compare
Member
Author
|
Ok, the test build was good 🎉 @bors r=alexcrichton p=1 |
Collaborator
|
📌 Commit 9926868 has been approved by |
Contributor
|
Could we give this p=2? Otherwise, there will be another 4h build before this one... |
Member
Author
|
Let's do even a p=3! @bors p=3 |
Collaborator
bors
added a commit
that referenced
this pull request
Jul 17, 2019
ci: fix LinuxTools PR builder missing environment variables This PR includes the new `public-credentials` variables group in PR builders, hopefully fixing sccache and toolstate. ~~Do not merge this yet as I want to do a test build first.~~ r? @alexcrichton fixes #62754 #62753
Collaborator
|
☀️ Test successful - checks-azure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the new
public-credentialsvariables group in PR builders, hopefully fixing sccache and toolstate.Do not merge this yet as I want to do a test build first.r? @alexcrichton
fixes #62754 #62753