fix span for errors E0537, E0535 & E0536#36354
Merged
Merged
Conversation
Contributor
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Contributor
|
@mikhail-m1 - since you're fixing spans, can you move some of the tests you're updating to src/test/ui? You can look around there to see how it works, but it's pretty simple. There's a corresponding .stderr for each test that matches with what the compiler would output. You can run the UI tests with: |
Contributor
Author
|
@jonathandturner I'll fix it |
Contributor
|
Great! Looks good. @bors r+ rollup |
Collaborator
|
📌 Commit fb85dd3 has been approved by |
Collaborator
Collaborator
1 similar comment
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #36182 as part of #35233