Update error message for E0243 and E0244

[Keats]

Fixes #35389 and #35390 as part of #35233.

r? @jonathandturner

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[Keats]

this errors:

unexpected errors (from JSON output): [
    Error {
        line_num: 19,
        kind: Some(
            Note
        ),
        msg: "in this expansion of println!"
    },
    Error {
        line_num: 19,
        kind: Some(
            Note
        ),
        msg: "in this expansion of println!"
    },
    Error {
        line_num: 19,
        kind: Some(
            Note
        ),
        msg: "in this expansion of println!"
    },
    Error {
        line_num: 19,
        kind: Some(
            Note
        ),
        msg: "in this expansion of println!"
    }
]

Remove the note make the test pass. Any idea?

[Keats]

according to irc, it's because once one NOTE is there, they must all be accounted for, should I remove mine or add the 4 missing?

[sophiajt]

Right. For the time being, would you mind adding the 4 missing ones? We'll probably do another pass later on that helps clean up macro errors, but for now we'll need to test for them.

[Keats]

Updated

[sophiajt]

Looks good!

@bors r+ rollup

[bors]

📌 Commit 24ddca0 has been approved by jonathandturner

[sophiajt]

@bors r-

Looks like you missed a couple, both of them in src/test/compile-fail/typeck-builtin-bound-type-parameters.rs on line 23 and 27:

unexpected errors (from JSON output): [
    Error {
        line_num: 23,
        kind: Some(
            Note
        ),
        msg: "unexpected lifetime parameter"
    },
    Error {
        line_num: 27,
        kind: Some(
            Note
        ),
        msg: "unexpected lifetime parameter"
    }
]

[Keats]

Had to rebase to see the errors, anyway fixed

[sophiajt]

@Keats - yeah I figured that might be the case. Thanks for updating.

@bors r+ rollup

[bors]

📌 Commit 02f3609 has been approved by jonathandturner