Rollup of leftover PRs in the queue#22548
Conversation
Otherwise, this line is a lie.
Adds an example of `else if` to the If section of The Rust Programming Language. r? @steveklabnik
Replaces the markdown link delimiters for the "Code of Conduct" link with the appropriate delimiters for using a link id r? @steveklabnik
The text is referring to the io module despite the code using the old_io module.
In `if loop {} {}`, the `if` is actually unreachable, but we didn't
handle that correctly and when trying to translate the `if` we tried to
branch on the "return value" of the loop expression, which is not an
`i1` and therefore triggered an LLVM assertion.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ 7e64 p=1 |
|
@bors r=huonw 1ecdb83 |
|
⌛ Testing commit 1ecdb83 with merge 80317f5... |
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: p=100 |
I had most of these tested locally, why not get them out of the way too?
Checks include declaration/implementation of unsafe functions, traits, and methods. This allows warning or forbidding all uses of unsafe code, whereas previously only unsafe blocks were caught by the lint. The lint has been renamed from `unsafe-blocks` to `unsafe-code` to reflect its new purpose. This is a minor [breaking-change] Closes rust-lang#22430
the punch line was cut off!
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors r=alexcrichton 7187ce1 |
|
🙀 You have the wrong number! Please try again with |
|
⌛ Testing commit 0184ecf with merge fcfd75f... |
The commit 1860ee5 has break the openbsd build. Repair it.
|
💔 Test failed - auto-linux-64-x-android-t |
The commit 1860ee5 has break the openbsd build. Repair it.
|
Restarting on the rollup since stuff changed and Windows hates me. |
I had most of these tested locally, why not get them out of the way too?
|
💔 Test failed - auto-mac-64-nopt-t |
|
@bors: retry |
|
@bors: r- Oops, sorry, not an intermittent. |
Failure in a doctest (can't repro locally), seems like an intermittent to me :/ |
I had most of these tested locally, why not get them out of the way too?
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry |
|
@bors: try Just in case, so that we can hammer out any failures on mac. |
|
⌛ Testing commit 686648d with merge 6c182b4... |
|
Seems to have merged into auto, not try. O.o |
|
@Manishearth This is normal. Homu tests The intention of this behavior was to get the exactly same test results from both the normal procedure and the The issue is tracked at barosl/homu#50, if you are interested. I already fixed it in my local repository, but didn't test it enough. I'm planning to push it soon, after the tests are done. |
|
For now, you can just fast-forward the merge commit made by Homu (6c182b4) to But I also hope the tests don't fail this time! |
|
Thanks, @barosl :) I closed the other PR because I was afraid that if those tests passed, homu would merge auto into master, and it would merge the wrong branch. |
I had most of these tested locally, why not get them out of the way too?
I had most of these tested locally, why not get them out of the way too?