Skip to content

Rid fn params of historical baggage (argument modes begone for good!)#156157

Draft
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:sleek-fn-params
Draft

Rid fn params of historical baggage (argument modes begone for good!)#156157
fmease wants to merge 1 commit into
rust-lang:mainfrom
fmease:sleek-fn-params

Conversation

@fmease

@fmease fmease commented May 4, 2026

Copy link
Copy Markdown
Member

FIXME(fmease): Add description.

@fmease fmease added T-lang Relevant to the language team T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. C-crater Category: Issue / PR for tracking crater runs labels May 4, 2026
@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 4, 2026
@fmease

fmease commented May 4, 2026

Copy link
Copy Markdown
Member Author

@bors try

rust-bors Bot pushed a commit that referenced this pull request May 4, 2026
Rid optional fn params of historical baggage (argument modes begone for good!)
@rust-bors

This comment has been minimized.

@fmease fmease changed the title Rid optional fn params of historical baggage (argument modes begone for good!) Rid fn params of historical baggage (argument modes begone for good!) May 4, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-21-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
Executing "/scripts/stage_2_test_set1.sh"
+ /scripts/stage_2_test_set1.sh
PR_CI_JOB set; skipping tidy
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
+ ../x.py --stage 2 test --skip tidy --skip compiler --skip src
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2026-04-14/rustfmt-nightly-aarch64-unknown-linux-gnu.tar.xz
---
---- [ui] tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs stdout ----
Saved the actual stderr to `/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rfcs/rfc-2565-param-attrs/attr-without-param/attr-without-param.stderr`
diff of stderr:

10 LL |     fn f(#[attr]) {}
11    |                 ^ expected parameter name
12 
- error: expected argument name, found `)`
+ error: expected type or parameter name, found `)`
14   --> $DIR/attr-without-param.rs:14:17
15    |
16 LL |     fn f(#[attr]);

-    |                 ^ expected argument name
+    |                 ^ expected type or parameter name
18 
19 error: aborting due to 3 previous errors
---
To only update this specific test, also pass `--test-args rfcs/rfc-2565-param-attrs/attr-without-param.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/ui/rfcs/rfc-2565-param-attrs/attr-without-param" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2015"
stdout: none
--- stderr -------------------------------
error: expected parameter name, found `)`
##[error]  --> /checkout/tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs:4:17
   |
LL |     fn f(#[attr]) {} //~ ERROR expected parameter name, found `)`
   |                 ^ expected parameter name

error: expected parameter name, found `)`
##[error]  --> /checkout/tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs:9:17
   |
LL |     fn f(#[attr]) {} //~ ERROR expected parameter name, found `)`
   |                 ^ expected parameter name

error: expected type or parameter name, found `)`
##[error]  --> /checkout/tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs:14:17
   |
LL |     fn f(#[attr]); //~ ERROR expected argument name, found `)`
   |                 ^ expected type or parameter name

error: aborting due to 3 previous errors
------------------------------------------

---- [ui] tests/ui/rfcs/rfc-2565-param-attrs/attr-without-param.rs stdout end ----

@rust-bors

rust-bors Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 3f7e3b1 (3f7e3b175fda7edbf81081bcd9b91b73f2f7993f, parent: cb40c25f6aebb637163d26bf76a680ed6e5d1eda)

@fmease

fmease commented May 4, 2026

Copy link
Copy Markdown
Member Author

@craterbot check

@craterbot

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-156157 created and queued.
🤖 Automatically detected try build 3f7e3b1
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026
@craterbot

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-156157 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-156157 is completed!
📊 2 regressed and 1 fixed (918169 total)
📊 5228 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-156157/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 21, 2026
@fmease

fmease commented May 21, 2026

Copy link
Copy Markdown
Member Author

@craterbot

Copy link
Copy Markdown
Collaborator

👌 Experiment pr-156157-1 created and queued.
🤖 Automatically detected try build 3f7e3b1
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2026
@craterbot

Copy link
Copy Markdown
Collaborator

🚧 Experiment pr-156157-1 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot

Copy link
Copy Markdown
Collaborator

🎉 Experiment pr-156157-1 is completed!
📊 2 regressed and 0 fixed (4920 total)
📊 1003 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-156157-1/retry-regressed-list.txt

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 23, 2026
@rust-bors

rust-bors Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #158864) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-crater Category: Issue / PR for tracking crater runs needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants