Skip to content

Add --ignore-scripts flag to npm install invocation#148665

Closed
yotamofek wants to merge 1 commit into
rust-lang:masterfrom
yotamofek:pr/npm-ignore-scripts
Closed

Add --ignore-scripts flag to npm install invocation#148665
yotamofek wants to merge 1 commit into
rust-lang:masterfrom
yotamofek:pr/npm-ignore-scripts

Conversation

@yotamofek

Copy link
Copy Markdown
Contributor

Newest version of rollup is broken: rollup/rollup#6168
This allows builds to pass until rollup releases a fix and/or we implement a better solution to the fact that npm is not honoring our package lock files

Newest version of rollup is broken: rollup/rollup#6168
This allows builds to pass until rollup releases a fix and/or we implement a better solution to the fact that npm is not honoring our package lock files
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 7, 2025
@rustbot

rustbot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Kobzol

Kobzol commented Nov 7, 2025

Copy link
Copy Markdown
Member

@bors r+ p=101

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 4f69a85 has been approved by Kobzol

It is now in the queue for this repository.

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
bors added a commit that referenced this pull request Nov 7, 2025
Add `--ignore-scripts` flag to npm install invocation

Newest version of rollup is broken: rollup/rollup#6168
This allows builds to pass until rollup releases a fix and/or we implement a better solution to the fact that npm is not honoring our package lock files
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 4f69a85 with merge 868b930...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@yotamofek

Copy link
Copy Markdown
Contributor Author

Closing this since it didn't work and rollup has released a fixed version in the meantime (rollup/rollup@616cad7)

@yotamofek yotamofek closed this Nov 7, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2025
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants