Skip to content

consider giving precedence to --config over RUST_BOOTSTRAP_CONFIG #93725

Closed
#93737
Closed
consider giving precedence to --config over RUST_BOOTSTRAP_CONFIG#93725
#93737
Assignees
mfrw
Labels
E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Description

@jyn514
jyn514
opened on Feb 7, 2022

rust/src/bootstrap/bootstrap.py

Lines 1224 to 1228 in 7b43cfc

# Read from `RUST_BOOTSTRAP_CONFIG`, then `--config`, then fallback to `config.toml` (if it
# exists).
toml_path = os.getenv('RUST_BOOTSTRAP_CONFIG') or args.config
if not toml_path and os.path.exists('config.toml'):
toml_path = 'config.toml'

It seems pretty strange to me that the env variable would take precedence over --config. It would be nice to switch the precedence.

cc @Mark-Simulacrum

Originally posted by @jyn514 in #92260 (comment)

Metadata

Metadata

Assignees

Labels

E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions