Skip to content

Document inclusive ranges.#1015

Merged
frewsxcv merged 2 commits into
rust-lang:masterfrom
alercah:inclusive-ranges
Mar 28, 2018
Merged

Document inclusive ranges.#1015
frewsxcv merged 2 commits into
rust-lang:masterfrom
alercah:inclusive-ranges

Conversation

@alercah

@alercah alercah commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

This provides documentation for rust-lang/rust#28237.

@alercah

alercah commented Jan 24, 2018

Copy link
Copy Markdown
Contributor Author

Note that the failing build is due to using an un-stabilized feature; it should pass once the feature is stabilized and released.

This provides documentation for rust-lang/rust#28237.
@steveklabnik

steveklabnik commented Mar 16, 2018

Copy link
Copy Markdown
Contributor

These just landed as stable in nightly. Let's retry travis!

@alercah

alercah commented Mar 16, 2018

Copy link
Copy Markdown
Contributor Author

Looks like it's failing; is it running stable and/or not up to date with the nightly?

@marioidival

Copy link
Copy Markdown
Member

@frewsxcv

frewsxcv commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

seems like we'll need to do one of three:

  • wait until it lands in stable rust, then merge
  • ...or update travis to use nightly rust
  • ...or update the code block to be rust,ignore

@steveklabnik thoughts?

@frewsxcv

Copy link
Copy Markdown
Contributor

actually, since rust-by-example now rides the docs release train, seems like it should be safe to do the second option and turn on nightly rust for travis ci

@steveklabnik

steveklabnik commented Mar 18, 2018

Copy link
Copy Markdown
Contributor

Yes, that's what we should do. Run with nightly but check there aren't any feature gates.

@alercah are you interested in tackling that? If not, I can take care of it tomorrow :)

@frewsxcv

Copy link
Copy Markdown
Contributor

looks good, thanks!

@frewsxcv frewsxcv merged commit 4747166 into rust-lang:master Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants