Change Hover#range to be optional#48004
Merged
Merged
Conversation
The docs of `Hover#range` state: > When missing, the editor will use the range at the current position or the current position itself. This implies that the `range` field should be optional as it can be missing.
Contributor
|
Looks good, merging but as said earlier: It is unlikely that monaco.d.ts. will properly support strict-null-checks because a good chunk of it is taken directly from our sources |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs of
Hover#rangein monaco.d.ts and modes.ts state:This implies that the
rangefield should be optional as it can be missing. When looking at the references toHover#range, we find out that there might pop up warnings inmodesContentHover.tswhen vscode is compiled withstrictNullCheckslater.