Skip to content

[INTEGRATED-TERMINAL] Clear selection by pressing escape key#47042

Merged
Tyriar merged 2 commits into
microsoft:masterfrom
ddruker:terminal/ddruker-pressing-escape-to-clear-seclection
Apr 2, 2018
Merged

[INTEGRATED-TERMINAL] Clear selection by pressing escape key#47042
Tyriar merged 2 commits into
microsoft:masterfrom
ddruker:terminal/ddruker-pressing-escape-to-clear-seclection

Conversation

@ddruker

@ddruker ddruker commented Mar 31, 2018

Copy link
Copy Markdown
Contributor

Overview

This PR will add a command that prevents the terminal window from placing the terminal prompt in view when the escape key is pressed and there is output selected.

Ref Microsoft/vscode#46728

Screenshots

  • The user can select and when escape is pressed, it will clear the selection. When there is no selection, it will default to normal behavior.

esc

@Tyriar Tyriar added this to the April 2018 milestone Apr 2, 2018
@Tyriar

Tyriar commented Apr 2, 2018

Copy link
Copy Markdown
Contributor

@ddruker looks good! I commited a change to make the action name more consistent with the rest and also cover the case where the find widget is visible: when both the find widget and a selection is up, escape will close the find widget, another escape will clear the selection, another escape will send esc to the shell.

@Tyriar Tyriar merged commit 1289571 into microsoft:master Apr 2, 2018
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants