Fix focus issues in disassembly view#129616
Merged
Merged
Conversation
Contributor
Author
Collaborator
|
This PR looks good. I have also tested out and fixes the linked issues. Thus merging in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #129523 and #129535
Some changes make more sense by combining the fixes to these two issues in the same PR.
Double clicking on instruction breakpoint in breakpoints view now passes focus to disassembly view, setting the focus to the entry containing target address.
mouseSupportis now disabled in disassembly view to disable selection. And so need to set focus at appropriate time, or there would be weird behaviors when navigating using arrow keys.