Add undefined to TextDocuments#get(uri: string)#339
Merged
Conversation
As the documentation of this funtion states: > * Returns the document for the given URI. Returns undefined if > * the document is not mananged by this instance. The return type does not reflect that it can return undefined. This commit adds that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the documentation of
TextDocuments#get(uri: string)funtion states:The return type does not reflect that it can return
undefined. This commit adds that.This might be a breaking change for existing code bases (which use
strictNullChecks), so feel free to reject this PR.