Skip to content
This repository was archived by the owner on Oct 2, 2021. It is now read-only.

Sanitize stack traces so they don't contain full file paths#322

Merged
roblourens merged 2 commits into
microsoft:masterfrom
digeff:sanitize_stack_traces
Apr 6, 2018
Merged

Sanitize stack traces so they don't contain full file paths#322
roblourens merged 2 commits into
microsoft:masterfrom
digeff:sanitize_stack_traces

Conversation

@digeff

@digeff digeff commented Apr 6, 2018

Copy link
Copy Markdown
Contributor

Sanitize stack traces so they don't contain full file paths

@roblourens roblourens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think the try/catch is necessary, .replace shouldn’t throw. I'll leave it for now. I'll fix this up for non-windows too.

@roblourens roblourens merged commit 97d90cc into microsoft:master Apr 6, 2018
@digeff digeff deleted the sanitize_stack_traces branch April 6, 2018 22:39
@roblourens roblourens added this to the April 2018 milestone Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants