Fix for sticky sidebar going off page on Desktop#444
Merged
Conversation
Contributor
Author
|
The sticky sidebar is a nice feature when browsing long docs. I have updated the PR to add scrolling to the sticky sidebar when it is taller than the screen with |
Member
|
@auchenberg can you please have a look. You know more about this than I do. |
Contributor
Author
|
@dbaeumer @auchenberg here is a rendered preview of the change. As you can see, not possible to scroll the sidebar currently and it goes off the page. After PR, it is possible to scroll the sidebar.
|
Contributor
|
LGTM! |
Member
|
@auchenberg thanks. Merging it in then. |
Member
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently the sticky sidebar is off the screen when expanded on desktop. It is not possible to scroll the sticky sidebar. I have a 1080p screen so this affects many users. Solution in this PR is to
disable stickiness on the sidebaradd scrolling to the sticky sidebar if needed.