Skip to content

Median inconsistent with pandas #31

Description

@hanslovsky

When running DataFrame.median I get results that are inconsistent with pandas. Here is an example in ipython:

In [48]: import pandas as pd

In [49]: import numpy as np

In [50]: import fireducks.pandas as fd

In [51]: def make_data(data_frame: type[pd.DataFrame | fd.DataFrame]) -> pd.DataFrame | fd.DataFrame:
    ...:     rng = np.random.default_rng(42)
    ...:     arr = rng.normal(size=(500_000, 6))
    ...:     df = data_frame(arr)
    ...:     return df.assign(md=np.arange(arr.shape[0]) % 7)
    ...: 

In [52]: data_pd = make_data(pd.DataFrame)

In [53]: data_fd = make_data(fd.DataFrame)

In [54]: data_fd.to_pandas().equals(data_pd)
Out[54]: True

In [55]: data_fd.drop(columns=["md"]).median()
Out[55]: 
0    0.001122
1    0.000344
2   -0.003104
3    0.001529
4    0.000973
5    0.004693
dtype: float64

In [56]: data_pd.drop(columns=["md"]).median()
Out[56]: 
0    0.000668
1   -0.000008
2   -0.002785
3    0.000264
4   -0.000166
5    0.003933
dtype: float64

In [58]: !pip freeze | grep -E 'fireducks|pandas'
fireducks==1.1.0
pandas==2.2.2

Versions are fireducks==1.1.0 and pandas==2.2.2.
If you see anything that I might be doing wrong, please let me know. Otherwise, this may be a bug.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions