[rust] Use PKG again for Firefox macOS downloads#17702
Merged
Merged
Conversation
The DMG-only workaround was added because PKG extraction failed with a cpio "bad magic value" error on newer Firefox builds. That root cause was fixed in #17691 (support for pbzx-compressed macOS .pkg payloads), so the version-based PKG/DMG selection can be restored.
This was referenced Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the version-based PKG/DMG artifact selection for Firefox macOS downloads in Selenium Manager.
In #17687 a workaround was added that forced DMG for all macOS Firefox downloads, because PKG extraction was failing with a cpio
bad magic valueerror on newer Firefox builds (Mozilla changed the internal pkg format to use pbzx compression).That root cause was fixed in #17691 (
Support pbzx-compressed macOS .pkg payloads), so the workaround is no longer needed. This reverts the firefox.rs change to once again use DMG only for Firefox < 68 and PKG for 68+.Motivation and Context
Removes a now-unnecessary workaround now that PKG extraction works again.
Types of changes
🤖 Generated with Claude Code