Skip to content

improve diagnostic suggestion when matching struct variants with tuple#158748

Open
Snxhit wants to merge 2 commits into
rust-lang:mainfrom
Snxhit:fix-struct-variant-suggestion
Open

improve diagnostic suggestion when matching struct variants with tuple#158748
Snxhit wants to merge 2 commits into
rust-lang:mainfrom
Snxhit:fix-struct-variant-suggestion

Conversation

@Snxhit

@Snxhit Snxhit commented Jul 3, 2026

Copy link
Copy Markdown

fixes #158641

changes:
passed sub_pats from resolve_pat_tuple_struct into report_unexpected_variant_res, match user's variable names to struct fields, fix suggestion name.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 3, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 3, 2026
@rustbot

rustbot commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @hanna-kruppe (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 21 candidates

@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading "fields are being ignored" help when changing a variant from tuple- to struct-like

4 participants