Move check_rustc_pub_transparent into the attribute parser#158496
Open
obeis wants to merge 2 commits into
Open
Move check_rustc_pub_transparent into the attribute parser#158496obeis wants to merge 2 commits into
check_rustc_pub_transparent into the attribute parser#158496obeis wants to merge 2 commits into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
4756680 to
36e0436
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
36e0436 to
a5834bd
Compare
JonathanBrouwer
requested changes
Jun 27, 2026
| .filter_map(|attr| attr.args.as_ref()?.as_list()) | ||
| .flat_map(|list| list.mixed()) | ||
| .filter_map(|item| item.meta_item()) | ||
| .any(|meta| meta.path().word_is(sym::transparent)) |
Contributor
There was a problem hiding this comment.
Hmmm I don't really like that we're duplicating some of the Repr parsing logic here.
How hard would it be to get access to the parsed repr attribute here?
Contributor
Author
There was a problem hiding this comment.
I see two ways to handle this:
- Extract a helper function:that holds the iteration logic currently inlined in
lint_helpers.rs. I'd move it next to the repr parser inrepr.rsso the logic lives in one place. - Add the parsed attributes to
FinalizeContext, so we can match onAttributeKind::Reprdirectly instead of re-walking the raw attribute args.
I think the second approach is much cleaner, since it avoids re-parsing entirely.
Contributor
There was a problem hiding this comment.
I prefer #2 strongly but the parsed attributes are only available after finalization, I think it's possible to work around that tho
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Open
29 tasks
the parsed attributes of an item were only fully populated after all finalizers had run, so `finalize_check` (run during finalization) could only inspect attribute *paths* via `FinalizeContext::all_attrs`, not the parsed `AttributeKind`s. split finalization into two passes: first run all finalizers to produce the parsed attributes, then run the cross-attribute checks. The checks are deferred via a new `AttributeParser::deferred_finalize_check`, and can now inspect the fully parsed attributes through a new `FinalizeContext::parsed_attrs` field.
the check that `#[rustc_pub_transparent]` is only applied to `#[repr(transparent)]` types needs to see the parsed `Repr` attribute, so it now lives in `RustcPubTransparentParser::finalize_check`, using the freshly available `FinalizeContext::parsed_attrs`.
a5834bd to
b6b2e9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #153101
Verify the
#[repr(transparent)]requirement inRustcPubTransparentParser::finalize_check, replacingcheck_rustc_pub_transparentinrustc_passes.r? @JonathanBrouwer