Skip to content

Add tests for make_bat_command_line argument reconstruction#155419

Open
StepfenShawn wants to merge 2 commits into
rust-lang:mainfrom
StepfenShawn:add-make-bat-command-line-tests
Open

Add tests for make_bat_command_line argument reconstruction#155419
StepfenShawn wants to merge 2 commits into
rust-lang:mainfrom
StepfenShawn:add-make-bat-command-line-tests

Conversation

@StepfenShawn

Copy link
Copy Markdown
Contributor

Resolves the FIXME in library/std/src/sys/args/windows.rs that noted tests were needed to ensure arguments are properly reconstructed by batch scripts.

Removed FIXME comment about testing argument reconstruction.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2026
@rustbot

rustbot commented Apr 17, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 7 candidates
  • Random selection from Mark-Simulacrum, jhpratt

@ChrisDenton

Copy link
Copy Markdown
Member

This should ideally be running .bat scripts with the arguments and checking they pass through ok. Unit testing the function is only of limited use.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2026
@rustbot

rustbot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants