This repository was archived by the owner on Jun 28, 2026. It is now read-only.
fix(breadcrumb): hide separator list items from accessibility tree#19568
Open
manichandra wants to merge 1 commit into
Open
fix(breadcrumb): hide separator list items from accessibility tree#19568manichandra wants to merge 1 commit into
manichandra wants to merge 1 commit into
Conversation
Separator <li> elements (chevron icons) were exposed in the accessibility tree, causing screen readers to announce decorative separators between breadcrumb items. Added aria-hidden="true" to both separator elements — the one following the home item and the one between each menu item. Fixes primefaces#19520 Relates to primefaces#13437
Contributor
Author
|
@mehmetcetin01140 can you please review and get this merged. let me know if I need to anything to pass the failing CI checks ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separator
Fixes Accessibility | Breadcrumb - separators aren't hidden in accessibility tree #19520
Relates to Accessibility | Breadcrumb - separetors aren't hidden and the list is not wrapped in a
navelement #13437Defect Fixes
When submitting a PR, please also create an issue documenting the error and manually link to an issue.
Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.