Skip to content

[dotnet] [build] Bump up C# lang version to 14.0 #17236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nvborisenko merged 2 commits into from
Mar 18, 2026
Merged

[dotnet] [build] Bump up C# lang version to 14.0 #17236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0616c
[dotnet] [build] Bump up C# lang version to 14.0
nvborisenko Mar 18, 2026
9e547f9
Update deps and fix magic bazel compilation error
nvborisenko Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ use_repo(esbuild, "esbuild_toolchains")
register_toolchains("@esbuild_toolchains//:all")

dotnet = use_extension("@rules_dotnet//dotnet:extensions.bzl", "dotnet")
dotnet.toolchain(dotnet_version = "8.0.203")
dotnet.toolchain(dotnet_version = "10.0.100")
use_repo(dotnet, "dotnet_toolchains")

selenium_paket = use_extension("//dotnet:paket.nuget_extension.bzl", "nuget_extension")
Expand Down
58 changes: 29 additions & 29 deletions dotnet/paket.nuget.bzl
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dotnet/private/docfx_repo.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ docfx_repo = repository_rule(
def _docfx_extension_impl(module_ctx):
docfx_repo(
name = "docfx",
version = "2.78.4",
sha256 = "56faca4233a743b446a7584ff8195d8bb09a33aaa97e9e089c1e6b112212a848",
version = "2.78.5",
sha256 = "924a104075e4bf7eae9520147ec10a809e82a8438ec330104581d219435968c5",
)
return module_ctx.extension_metadata(reproducible = True)

Expand Down
4 changes: 2 additions & 2 deletions dotnet/src/support/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ csharp_library(
"//dotnet:source_files_support_needs_from_core",
],
out = "WebDriver.Support",
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
target_frameworks = [
"netstandard2.0",
Expand Down Expand Up @@ -77,7 +77,7 @@ csharp_library(
],
out = "WebDriver.Support.StrongNamed",
keyfile = "//dotnet:Selenium.snk",
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
target_frameworks = [
"netstandard2.0",
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/support/Selenium.WebDriver.Support.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<AssemblyName>WebDriver.Support</AssemblyName>
<RootNamespace>OpenQA.Selenium.Support</RootNamespace>
<BuildSystem>visual-studio</BuildSystem>
<LangVersion>12.0</LangVersion>
<LangVersion>14.0</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
12 changes: 6 additions & 6 deletions dotnet/src/webdriver/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ csharp_library(
internals_visible_to = [
"WebDriver.Common.Tests",
],
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
target_frameworks = [
"net462",
Expand Down Expand Up @@ -84,7 +84,7 @@ csharp_library(
internals_visible_to = [
"WebDriver.Common.Tests",
],
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
resources = [],
target_frameworks = [
Expand Down Expand Up @@ -121,7 +121,7 @@ csharp_library(
internals_visible_to = [
"WebDriver.Common.Tests",
],
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
resources = [],
target_frameworks = [
Expand All @@ -143,7 +143,7 @@ csharp_library(
]) + devtools_version_targets(),
out = "WebDriver.StrongNamed",
keyfile = "//dotnet:Selenium.snk",
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
target_frameworks = [
"net462",
Expand Down Expand Up @@ -174,7 +174,7 @@ csharp_library(
]) + devtools_version_targets(),
out = "WebDriver.StrongNamed",
keyfile = "//dotnet:Selenium.snk",
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
resources = [],
target_frameworks = [
Expand Down Expand Up @@ -209,7 +209,7 @@ csharp_library(
"NET8_0_OR_GREATER",
],
keyfile = "//dotnet:Selenium.snk",
langversion = "12.0",
langversion = "14.0",
nullable = "enable",
resources = [],
target_frameworks = [
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/Selenium.WebDriver.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<TargetFrameworks>net462;netstandard2.0;net8.0;</TargetFrameworks>
<AssemblyName>WebDriver</AssemblyName>
<RootNamespace>OpenQA.Selenium</RootNamespace>
<LangVersion>12.0</LangVersion>
<LangVersion>14.0</LangVersion>
<Nullable>enable</Nullable>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions dotnet/test/common/Environment/EnvironmentManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ private EnvironmentManager()
// Search for the driver type in the all assemblies,
// bazel uses unpredictable assembly names to execute tests
driverType = AppDomain.CurrentDomain.GetAssemblies()
.AsEnumerable()
.Reverse()
.Select(assembly => assembly.GetType(driverConfig.DriverTypeName))
.FirstOrDefault(t => t != null);
Expand Down
Loading