Skip to content

fix: Handle date clearing in Activity view#554

Merged
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
pkvach:dev/fix-date-clearing-in-activity-view
May 1, 2024
Merged

fix: Handle date clearing in Activity view#554
ErikBjare merged 1 commit into
ActivityWatch:masterfrom
pkvach:dev/fix-date-clearing-in-activity-view

Conversation

@pkvach

@pkvach pkvach commented Apr 8, 2024

Copy link
Copy Markdown
Contributor

Fixes ActivityWatch/activitywatch#1023

Improved date validation in the Activity view by checking if the date is valid using moment.js before proceeding with date manipulations. This prevents errors when the date is cleared or invalid.

@ErikBjare

Copy link
Copy Markdown
Member

Sorry for the slow review.
Looks good! Waiting for CI to pass.

@ErikBjare ErikBjare merged commit 97a1089 into ActivityWatch:master May 1, 2024
@pkvach pkvach deleted the dev/fix-date-clearing-in-activity-view branch May 2, 2024 04:52
@pkvach

pkvach commented May 2, 2024

Copy link
Copy Markdown
Contributor Author

No problem at all. Thank you for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date "Clear" results in internal error

2 participants