fix: restore individual cell values on undo for multi-cell paste#1199
Merged
Conversation
Collaborator
Author
|
validated the fix in Slickgrid-Universal in the UI and it works and the fix is valid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #917
vibe coded a fix with Copilot
Description
Fixes issue #917 where undoing a multi-cell paste operation in CellExternalCopyManager incorrectly restores all cells to the same value instead of their individual previous values.
Root Cause
When pasting a single cell value to multiple cells (
oneCellToMultiple), the undo function was incorrectly retrieving the old value. It usedoldValues[0][0]for all cells instead ofoldValues[y][x - xOffset], causing all cells to be restored to the first cell's previous value.Reproduction Steps
Solution
oneCellToMultiplecondition from the undo functionxOffsettracking to handle hidden columns correctly (consistent with the execute function)oldValues[y][x - xOffset]Testing
Impact